Bugfix/immediate exceptions not working with namespaces #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you 🍨 |
mroderick
added a commit
that referenced
this pull request
Mar 2, 2015
…t-working-with-namespaces Bugfix/immediate exceptions not working with namespaces
rubennorte
deleted the
bugfix/immediate-exceptions-not-working-with-namespaces
branch
|
You're welcome. When do you expect to release a new version to npm? |
It's been published now :) |
|
Thanks! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug with immediate exceptions not being thrown if they come from handlers subscribed to namespaces of the topic being published (subscribe: 'buy' vs publish: 'buy.tomatoes'). The fix is pretty trivial.