Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add method for getting all shows #3

Merged
merged 6 commits into from
Jul 18, 2019
Merged

add method for getting all shows #3

merged 6 commits into from
Jul 18, 2019

Conversation

jeffrg
Copy link

@jeffrg jeffrg commented Jul 16, 2019 •
edited
Loading

@coveralls
Copy link

coveralls commented Jul 16, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 86

  • 22 of 26 (84.62%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.8%) to 68.108%
Changes Missing Coverage Covered Lines Changed/Added Lines %
tvmaze/client.go 4 6 66.67%
tvmaze/show.go 15 17 88.24%
Totals Coverage Status
Change from base Build 72: 1.8%
Covered Lines: 126
Relevant Lines: 185
💛 - Coveralls

mrobinsn
mrobinsn requested changes Jul 17, 2019
View reviewed changes
Copy link
Owner

@mrobinsn mrobinsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing! Couple of comments.

tvmaze/show.go Outdated Show resolved Hide resolved
tvmaze/show.go Outdated Show resolved Hide resolved
jeffrg
jeffrg commented Jul 17, 2019
View reviewed changes
tvmaze/episode.go Outdated Show resolved Hide resolved
@jeffrg
Copy link
Author

jeffrg commented Jul 17, 2019 •
edited
Loading

429s that were ignored are now returned as errors, as a bonus.

@mrobinsn mrobinsn self-assigned this Jul 18, 2019
mrobinsn
mrobinsn approved these changes Jul 18, 2019
View reviewed changes
Copy link
Owner

@mrobinsn mrobinsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you for the edits.

@mrobinsn mrobinsn merged commit ace96d9 into mrobinsn:master Jul 18, 2019
@mrobinsn
Copy link
Owner

Released in v1.1.0: https://github.com/mrobinsn/go-tvmaze/releases/tag/v1.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrobinsn mrobinsn mrobinsn approved these changes

Assignees

@mrobinsn mrobinsn

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jeffrg @coveralls @mrobinsn