Skip to content
This repository has been archived by the owner on Jan 4, 2025. It is now read-only.

Add torrent stopped #13

Merged
merged 6 commits into from
Oct 23, 2020
Merged

Conversation

burmudar
Copy link
Contributor

Add methods to be able to add a torrent in stopped state

@burmudar burmudar closed this Oct 17, 2020
@burmudar burmudar deleted the add-torrent-stopped branch October 17, 2020 11:12
@burmudar burmudar restored the add-torrent-stopped branch October 17, 2020 11:13
@mrobinsn
Copy link
Owner

@burmudar Did you mean to close this?

@mrobinsn mrobinsn reopened this Oct 18, 2020
@burmudar
Copy link
Contributor Author

Hey! Yeah I did. I haven’t tested with the unit tests. Wanted to create a container for that

@mrobinsn
Copy link
Owner

Cool. I just fixed the unit tests on master, if you merge master back into this branch Travis CI should run the unit tests automatically against a rutorrent Docker container.

@burmudar burmudar force-pushed the add-torrent-stopped branch from 9d41669 to e100c8a Compare October 20, 2020 19:11
@coveralls
Copy link

Pull Request Test Coverage Report for Build 199

  • 8 of 12 (66.67%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.3%) to 46.882%

Changes Missing Coverage Covered Lines Changed/Added Lines %
rtorrent/rtorrent.go 8 12 66.67%
Totals Coverage Status
Change from base Build 194: 0.3%
Covered Lines: 391
Relevant Lines: 834

💛 - Coveralls

@burmudar
Copy link
Contributor Author

@mrobinsn Finally got round to fixing the tests!

Added two methods

  • AddStopped - adds a torrent by url in stopped state
  • AddTorrentStoped - adds a torrent file in stopped state

@mrobinsn mrobinsn merged commit 613b8d5 into mrobinsn:master Oct 23, 2020
@mrobinsn
Copy link
Owner

Thanks for the contribution @burmudar !

This is tagged and released in https://github.com/mrobinsn/go-rtorrent/releases/tag/v1.4.0

@burmudar burmudar deleted the add-torrent-stopped branch October 23, 2020 21:33
mrobinsn added a commit that referenced this pull request Apr 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants