Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New feature: RSS #7

Merged
merged 3 commits into from
May 9, 2017
Merged

New feature: RSS #7

merged 3 commits into from
May 9, 2017

Conversation

imba3r
Copy link
Contributor

@imba3r imba3r commented May 4, 2017

Hi,

great library - thank you for this! I needed RSS capabilities, maybe you are interested in this. Most indexers that I'm aware of have a RSS feed under /rss whereas the normal api is under /api. The results and query parameters are pretty much the same. Note that users will have to specify their indexer base URL without the trailing /api in it - so this is kind of a breaking change. Let me know if you are interested and I will also update the Readme.

Best regards,
imba3r

  • Build RSS / API url based on called function.
  • Fetch RSS results (possible to specify count).
  • Fetch RSS up to a given NZB id.
  • Parse usenetdate (different to pubdate).

* Build RSS / API url based on called function.
* Fetch RSS results (possible to specify count).
* Fetch RSS up to a given NZB id.
* Parse usenetdate (different to pubdate).
@mrobinsn
Copy link
Owner

mrobinsn commented May 5, 2017

@imba3r This looks great!

Please go ahead and update the README with the correct base URL. Then I will see no reason not to go ahead and merge this in. I will create a new major release noting the breaking change -- shouldn't be a problem.

@imba3r
Copy link
Contributor Author

imba3r commented May 8, 2017

Hi @mrobinsn,

I updated the readme about the /api and /rss base URL suffix. I also added another commit that adds two minor things:

  • Attempt to parse date in RFC3339 if RFC1123Z failed (I've seen those a couple of times).
  • Added Error Code + Description to Response struct, if those are filled return an error with the description.

If you don't want that in this Pull-Request I can leave that out.

Best regards,
imba3r

@mrobinsn mrobinsn merged commit 56a726e into mrobinsn:master May 9, 2017
@mrobinsn mrobinsn self-assigned this May 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants