Add movie support, quite a bit of cleanup #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Local responses in tests/fixtures/api/ * Added various extra attributes * Added SearchWithTVDB method * Restructured tests to be able to add movie stuff next
* Make the test verbage more goconvey-y * Rename the `category` Client.Searc* param to `categories` * New `categories` param is now a slice of ints * Add splitCats method to the Client
|
Excellent, LGTM |
mrobinsn
pushed a commit
that referenced
this pull request
Mar 20, 2016
Add movie support, quite a bit of cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure where you're wanting to go with this, but I needed the ability to do movie searches so I dug in. Ended up doing quite a bit more than I intended so here's the high points: