Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tests #54

Merged
merged 2 commits into from
Dec 17, 2023
Merged

Update tests #54

merged 2 commits into from
Dec 17, 2023

Conversation

mrloop
Copy link
Owner

@mrloop mrloop commented Dec 17, 2023

Improve tests

@mrloop
Remove unused assertations
6aad3e6 
These two assertions were never called as `window.sa_event` set on the
script loading, and in these two tests we are setting before script
loaded.
@mrloop
Use assert.async rather than assert.expect
23f1421
@mrloop mrloop added the enhancement New feature or request label Dec 17, 2023
@mrloop mrloop merged commit 17cc4d9 into main Dec 17, 2023
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mrloop