Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a set_fact when guacamole version is 1.5.4 and debian OS #47

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

roumano
Copy link
Collaborator

@roumano roumano commented Jan 11, 2024

Fixing issue #46

it's will set a environment to permit compile guacamole
if the env is enable on old version (like 1.5.3), it's failed to compile sadly it's produce a warning on ansible-playbook :

[WARNING]: could not parse environment value, skipping: ['{{ guacamole_compile_environment | default(omit) }}']

The when condition can easily add other OS version as they also impacted about this compile issue

Description

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

it's will set a environment to permit compile guacamole

if the env is enable on old version (like 1.5.3), it's failed to compile
sadly it's produce a warning on ansible-playbook :
```
[WARNING]: could not parse environment value, skipping: ['{{ guacamole_compile_environment | default(omit) }}']
```
Copy link

stale bot commented Mar 12, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Mar 12, 2024
@roumano roumano merged commit bb87ed6 into master Mar 12, 2024
4 checks passed
@delete-merged-branch delete-merged-branch bot deleted the fix-compile_issue_1.5.4 branch March 12, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant