Make SOUR references work like GEDCOM 5.5 says they should #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd be happy to pull this, but the formatting needs to be cleaned up to match PSR-2 standards, and I'd really like to have a test added to verify the fix, and to prevent it from being broken again. See the recent tests I added under Thanks for submitting the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request should make the SourRef parser conform to the source citation documentation here.
Cases where a source is a reference are now handled differently than inline sources. In addition, OBJE support was absent from from SourRef while the spec says it should be supported.
This would also close issue #15. In the case of #15, the SOUR is detected as a reference and the CONC tags are sent to logUnhandledRecord.