Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the plain JSON.stringify function to encode default values #389

Merged
merged 2 commits into from
Nov 20, 2023

Conversation

cmaster11
Copy link
Collaborator

The previous wrapValue function was incomplete, in the sense that strings with e.g. backslashes would be encoded in the wrong way. In the end, looking at the overall behavior of wrapValue, it seems to want to behave exactly in the same way as JSON.stringify, so it may be worth just replacing it once and for all.

Copy link

codecov bot commented Nov 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (43f2159) 98.69% compared to head (b0d0c4e) 98.67%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #389      +/-   ##
==========================================
- Coverage   98.69%   98.67%   -0.03%     
==========================================
  Files           9        9              
  Lines         537      528       -9     
  Branches      208      204       -4     
==========================================
- Hits          530      521       -9     
  Misses          7        7              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@mrjono1 mrjono1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I must have gone down some rabbit hole of debugging, thanks for this fix

@mrjono1 mrjono1 merged commit 32cd4ce into mrjono1:master Nov 20, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants