Add support for Joi.any().cast() to string and number types #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjb085
commented
Sep 1, 2021
|
Thankyou for the PR! I'll review it soon |
mrjono1
reviewed
Sep 3, 2021
Codecov Report
@@ Coverage Diff @@
## master #142 +/- ##
==========================================
+ Coverage 97.82% 97.84% +0.01%
==========================================
Files 8 8
Lines 414 417 +3
Branches 134 136 +2
==========================================
+ Hits 405 408 +3
Misses 9 9
Continue to review full report at Codecov.
|
mrjono1
reviewed
Sep 4, 2021
|
looks good me ready to merge? |
|
@mrjono1 - All set. I somehow missed actually updating the README, but I've now added the cast function noting support for string and number under "Joi Features Supported" section |
|
@kjb085 thankyou, this has been released under https://github.com/mrjono1/joi-to-typescript/releases/tag/2.2.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently any use of
Joi.any().cast()fails. It supports converting tostring,number,Map, andSet- given that handling the generics forMapandSetadds some additional complexities, I've added the base level of support forstringandnumbertypes.