Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

let which-key handle key binding if which-key integration is used #122

Merged
merged 9 commits into from
Apr 17, 2022

Conversation

mrjones2014
Copy link
Owner

Resolves: #[issue number]

How to Test

  1. Please leave detailed testing instructions

Testing for Regressions

I have tested the following:

  • Triggering keymaps from legendary.nvim in all modes (normal, insert, visual)
  • Creating keymaps via legendary.nvim, then triggering via the keymap in all modes (normal, insert, visual)
  • Triggering commands from legendary.nvim in all modes (normal, insert, visual)
  • Creating commands via legendary.nvim, then running the command manually from the command line
  • augroup/autocmds created through legendary.nvim work correctly

@mrjones2014
Copy link
Owner Author

@bennypowers you use which-key right? Would you mind testing this out?

Original purpose was for something else but I think it’s a good improvement regardless. Removes some redundant mapping.

@bennypowers
Copy link

how would this affect my config?

@mrjones2014
Copy link
Owner Author

You shouldn't need to change anything, I think I'm just doing unnecessary work, so as long as nothing breaks for you testing this branch, it should be all good.

@bennypowers
Copy link

I poked around for a few minutes and both legendary menu and which-key bindings seem to work fine

@mrjones2014
Copy link
Owner Author

Thanks for testing! I’ll get this merged soon then.

@mrjones2014
Copy link
Owner Author

@bennypowers I made a few changes, can you test one more time?

@mrjones2014 mrjones2014 changed the title Draft: let which-key handle key binding if which-key integration is used let which-key handle key binding if which-key integration is used Apr 17, 2022
@bennypowers
Copy link

yeah looks ok. I didn't do exhaustive testing, but I did confirm that at least one or two of the bindings that I set up in my which-key config file appeared in both places

@mrjones2014
Copy link
Owner Author

Awesome, that's all that this PR should really affect. Going to merge. Thanks!

@mrjones2014 mrjones2014 merged commit bcfd306 into master Apr 17, 2022
@mrjones2014 mrjones2014 deleted the matjones/which-key-handles-bindings branch April 17, 2022 15:37
mrjones2014 added a commit that referenced this pull request Nov 14, 2022
…indings

let which-key handle key binding if which-key integration is used

Former-commit-id: bcfd306
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants