-
-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
let which-key handle key binding if which-key integration is used #122
Conversation
@bennypowers you use which-key right? Would you mind testing this out? Original purpose was for something else but I think it’s a good improvement regardless. Removes some redundant mapping. |
how would this affect my config? |
You shouldn't need to change anything, I think I'm just doing unnecessary work, so as long as nothing breaks for you testing this branch, it should be all good. |
I poked around for a few minutes and both legendary menu and which-key bindings seem to work fine |
Thanks for testing! I’ll get this merged soon then. |
@bennypowers I made a few changes, can you test one more time? |
yeah looks ok. I didn't do exhaustive testing, but I did confirm that at least one or two of the bindings that I set up in my which-key config file appeared in both places |
Awesome, that's all that this PR should really affect. Going to merge. Thanks! |
…indings let which-key handle key binding if which-key integration is used Former-commit-id: bcfd306
Resolves: #[issue number]
How to Test
Testing for Regressions
I have tested the following:
legendary.nvim
in all modes (normal, insert, visual)legendary.nvim
, then triggering via the keymap in all modes (normal, insert, visual)legendary.nvim
in all modes (normal, insert, visual)legendary.nvim
, then running the command manually from the command lineaugroup
/autocmd
s created throughlegendary.nvim
work correctly