Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check commits instead of PR text for pull requests #122

Merged
merged 4 commits into from
Nov 15, 2023
Merged

Check commits instead of PR text for pull requests #122

merged 4 commits into from
Nov 15, 2023

Conversation

Fryuni
Copy link
Contributor

@Fryuni Fryuni commented Nov 6, 2023

@Fryuni
Copy link
Contributor Author

Fryuni commented Nov 6, 2023

Here is the run on our repo showing how the failure is reported:

https://github.com/croct-tech/opinionated-commit-message/actions/runs/6710498865/job/18235816627

@mristin
Copy link
Owner

mristin commented Nov 6, 2023

@Fryuni can you please rebase your branch so that we can re-run the CI?

@Fryuni Fryuni force-pushed the check-all-commits branch from 3ee0241 to 4ec89f6 Compare November 9, 2023 17:01
Fryuni added 2 commits November 9, 2023 14:12
@Fryuni
Update README
4ecc138 
Signed-off-by: Luiz Ferraz <[email protected]>
@Fryuni
Update README
40d001a 
Signed-off-by: Luiz Ferraz <[email protected]>
@Fryuni
Copy link
Contributor Author

Fryuni commented Nov 9, 2023

@mristin rebased, and README updated

@Fryuni
Remove issue from README
1880cfa 
Signed-off-by: Luiz Ferraz <[email protected]>
@mristin mristin merged commit e4d81e5 into mristin:master Nov 15, 2023
3 checks passed
@mristin
Copy link
Owner

mristin commented Nov 15, 2023

Thanks, @Fryuni! Should I release a minor version?

@Fryuni
Copy link
Contributor Author

Fryuni commented Nov 15, 2023

@mristin I'll try to implement the fix for merge commits today, if it works we can wait until that lands and release together.

If I find that it will take more time I'll ping you later so you can cut a release :)

@Fryuni Fryuni deleted the check-all-commits branch November 16, 2023 13:05
mristin added a commit that referenced this pull request Feb 15, 2024
@mristin
Release 3.1.0
1c6c2f4 
* Upgrade action and packages to Node 20 (#126)
* Add support for ignored patterns (#124)
* Check commits instead of PR text for pull requests (#122)
* Refactor inputs as named parameters (#121)
* Update all dependencies (#120)
@mristin mristin mentioned this pull request Feb 15, 2024
Merged
mristin added a commit that referenced this pull request Feb 15, 2024
@mristin
Release 3.1.0 (#127)
bd3d91a 
* Upgrade action and packages to Node 20 (#126)
* Add support for ignored patterns (#124)
* Check commits instead of PR text for pull requests (#122)
* Refactor inputs as named parameters (#121)
* Update all dependencies (#120)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Check commits instead of PR text for pull requests
2 participants
@Fryuni @mristin