Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opera version? #10

Open
mathiasbynens opened this issue Sep 12, 2014 · 6 comments
Open

Opera version? #10

mathiasbynens opened this issue Sep 12, 2014 · 6 comments

Comments

@mathiasbynens
Copy link

Any chance you’d be willing to upload this to https://addons.opera.com/en/developer/upload/, so that Opera users can enjoy your extension too?

You probably don’t even have to change the code.

cc @shwetank

@mrflix
Copy link
Owner

mrflix commented Sep 12, 2014

I just tried it out in Opera and unfortunately it needs some work...
Any chance that you'd be willing to optimise the extension for Opera?

Ps.: see you at the cssconf.eu party tonight.

@shwetank
Copy link

Hey Felix,

If you let me know what exactly needs work to make it work in Opera
properly, then I would be willing to help.

Cheers,

On Fri, Sep 12, 2014 at 5:17 PM, Felix Niklas [email protected]
wrote:

I just tried it out in Opera and unfortunately it needs some work...
Any chance that you'd be willing to optimise the extension for Opera?

Ps.: see you at the cssconf.eu party tonight.


Reply to this email directly or view it on GitHub
#10 (comment).

Shwetank Dixit
http://www.shwetankdixit.com
http://www.incredicampus.com

@mrflix
Copy link
Owner

mrflix commented Sep 12, 2014

Well I installed it and added the keyboard shortcut. After that I tried out the keyboard shortcut on a freshly loaded website and the shortcut turned the extension on but it then instantly got turned off again (judging from the flashing dimensions icon). Turning it on and off manually worked fine.

I also got a problem when trying to use the shortcut shortly after scrolling (or bevor scrolling, I don't remember). Apparently alt + scroll zooms the page.

@shwetank
Copy link

Hi,

I see that the shortcut command is mentioned as 'Ctrl+D' ... and 'Command+D' in Mac. I'm a bit rusty on windows, but I know that in Mac, 'Command+D' is a reserved keyword as a browser command which adds current page to bookmarks. For comparison I also installed this in Chrome Canary and tried the shortcut there, and it failed there too (for the same reason - the Command+D shortcut brought up the 'add this page to bookmarks' interface).

I downloaded and tweaked the extension so that it has a shortcut which isn't reserved (I tried Command+Shift+K and then later even Command+K) and it worked fine.

Note to self: Don't forget to delete the extension and load it again if you change the bookmark shortcut. Just reloading the extension in developer mode will not kick in the changed shortcut. I spent 5 minutes confused before remembering this!

@mathiasbynens
Copy link
Author

@mrflix Can you confirm @shwetank’s findings?

@mrflix
Copy link
Owner

mrflix commented Sep 18, 2014

I changed the default shortcut in the manifest to 'Alt+D', which was a great idea @shwetank.
But I still have bugs in Opera:

  • sometimes the deactivation of dimensions in a tab does not get called
  • activating via shortcut directly deactivates it again

I pushed the current code which contains new features: climbing up gradients #3, measuring an area (press ALT) #14 and hidden cursor #16.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants