-
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add #[no_std] support. (Closes #3) #10
Conversation
Oh, one note I just found could serve as a word of caution:
See here. |
LGTM. You can test easily by building for a no_std target, such as thumbv7em-none-eabi. Just add that target with rustup and specify with |
Looks like a dep is using
|
I think as long as the library is no_std, the examples don't have to be, which will make them simpler. If you want some code that runs on an embedded target, I'd put it in a different crate and use cortex-m-quickstart. You should also be able to use the built in targets. |
@thejpster thanks for your advice. I merged the changes for no_std support in #15. |
This makes the necessary changes to make this crate running with
#[no_std]
.I'm a bit surprised that it was that easy and it feels like I'm missing something here.
It was simply replacing
std
withcore
.If you wonder about the dependency to the log crate, that one is
#[no_std]
by default since 0.4 (2017-12-24 🎄).@thejpster, any comments before merging?