New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Geometries: Reuse `arrayNeedsUint32()` from core. #30408

Merged

Mugen87 merged 1 commit into mrdoob:dev from Mugen87:dev3

Jan 27, 2025

Collaborator

Mugen87 commented Jan 27, 2025

Fixed #30404.

Description

The PR makes sure src/renderers/common/Geometries.js reuses arrayNeedsUint32() from src/utils.js and does not rely on a copy.


          Geometries: Reuse arrayNeedsUint32() from core.

d5e814c

github-actions bot commented Jan 27, 2025

📦 Bundle size

Full ESM build, minified and gzipped.

	Before	After	Diff
WebGL	336.27 78.29	336.27 78.29	+0 B +0 B
WebGPU	512.43 142.35	512.38 142.34	-50 B -10 B
WebGPU Nodes	511.9 142.25	511.85 142.24	-50 B -9 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

	Before	After	Diff
WebGL	465.25 112.13	465.25 112.13	+0 B +0 B
WebGPU	586.38 159.04	586.31 159	-68 B -33 B
WebGPU Nodes	541.76 148.6	541.7 148.55	-68 B -48 B

Mugen87 merged commit cb91f1a into mrdoob:dev

12 checks passed

Mugen87 added this to the r173 milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet