Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGPURenderer: Improve TimestampQueryPool logs #30393

Merged

Conversation

RenaudRohlinger
Copy link
Collaborator

@RenaudRohlinger RenaudRohlinger commented Jan 25, 2025

Related issue: #30359 (comment)

Description

Improved TimestampQueryPool logs, it is now a lot more explicit:
Screenshot 2025-01-25 at 13 53 03

Fixed several examples, notably compute_sort_bitonic, which was incompatible with WebGL due to the use of workgroups.

Also the comparison between production and dev (now using TimestampQueryPool) is promising. Accuracy has significantly improved, and responsiveness is impressive. A notable example is compute_sort_bitonic, which runs multiple compute programs per frame.

This contribution is funded by Utsubo

@RenaudRohlinger RenaudRohlinger added this to the r173 milestone Jan 25, 2025
Copy link

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 336.27
78.29
336.27
78.29
+0 B
+0 B
WebGPU 512.03
142.15
512.43
142.35
+406 B
+206 B
WebGPU Nodes 511.49
142.04
511.9
142.25
+406 B
+207 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 465.25
112.13
465.25
112.13
+0 B
+0 B
WebGPU 585.97
158.83
586.38
159.04
+406 B
+203 B
WebGPU Nodes 541.36
148.4
541.76
148.6
+406 B
+199 B

@RenaudRohlinger RenaudRohlinger merged commit 92bd4f3 into mrdoob:dev Jan 25, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant