Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build. #29985

Merged
merged 1 commit into from
Nov 28, 2024
Merged

Fix build. #29985

merged 1 commit into from
Nov 28, 2024

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Nov 28, 2024

Related issue: 27d1054

Description

Fixes the broken builds.

@Mugen87 Mugen87 merged commit ada8ab4 into mrdoob:dev Nov 28, 2024
1 check was pending
Mugen87 referenced this pull request Nov 28, 2024
@mrdoob
Renamed Three.core.js to Three.Core.js.
27d1054
@github-actions GitHub Actions
Copy link

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 339.14
78.99		 339.14
78.99		 +0 B
+0 B
WebGPU 484.02
134.26		 484.02
134.26		 +0 B
+0 B
WebGPU Nodes 483.49
134.16		 483.49
134.16		 +0 B
+0 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 464.62
111.98		 464.62
111.98		 +0 B
+0 B
WebGPU 552.83
149.53		 552.83
149.53		 +0 B
+0 B
WebGPU Nodes 508.71
139.25		 508.71
139.25		 +0 B
+0 B

cmhhelgeson pushed a commit to cmhhelgeson/three.js that referenced this pull request Dec 5, 2024
@Mugen87 @cmhhelgeson
Fix build. (mrdoob#29985)
d26eafe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Mugen87