Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GLTFExporter: Better defaults for metallic and roughness factors. #29692

Merged
merged 3 commits into from
Oct 19, 2024

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Oct 18, 2024

Fixed #29664.

Description

If GLTFExporter encounters a material which is no PBR material, it uses the same defaults for metallicFactor and roughnessFactor like metalness and roughness of MeshStandardMaterial.

@Mugen87 Mugen87 added this to the r170 milestone Oct 18, 2024
examples/jsm/exporters/GLTFExporter.js Outdated Show resolved Hide resolved
@Mugen87 Mugen87 merged commit 2976aa1 into mrdoob:dev Oct 19, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GLTFExporter sets a default metalness of 0.5
3 participants