Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGPUBackend: Fix generateMipmaps() in texture layers #29151

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

sunag
Copy link
Collaborator

@sunag sunag commented Aug 16, 2024

Related issue: Closes #29145

@sunag sunag added this to the r168 milestone Aug 16, 2024
@sunag sunag changed the title WebGPUBackend: generateMipmaps() in texture layers WebGPUBackend: Fix generateMipmaps() in texture layers Aug 16, 2024
Copy link

📦 Bundle size

Full ESM build, minified and gzipped.

Filesize dev Filesize PR Diff
685.4 kB (169.7 kB) 685.4 kB (169.7 kB) +0 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Filesize dev Filesize PR Diff
462 kB (111.4 kB) 462 kB (111.4 kB) +0 B

@sunag sunag marked this pull request as ready for review August 16, 2024 02:46
@sunag sunag merged commit 4046207 into mrdoob:dev Aug 16, 2024
12 checks passed
@sunag sunag deleted the dev-layers branch August 16, 2024 02:47
@Spiri0
Copy link
Contributor

Spiri0 commented Aug 16, 2024

wow, that was quick. I made the change locally in src/renderers/webgpu/utils/WebGPUTextureUtils.js to test it. Normally that's enough. Unfortunately, I still only see mipmaps for the first texture in the array. Do I need to pay attention to anything else?

@sunag
Copy link
Collaborator Author

sunag commented Aug 16, 2024

Maybe be necessary build again three.webgpu.js

@Spiri0
Copy link
Contributor

Spiri0 commented Aug 16, 2024

Ah I understand, since r167 with three.webgpu.js the node system has become a core part. You were right sunag. I just had to rebuild three.webgpu.js
Now it's working properly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In webgpu, the mipmaps for all textures except the first one are missing for a texture_2d_array
2 participants