ArcballControls: Derive from Controls.

[Mugen87]

Related issue: #29085

Description

Same as #29085.

[s-rigaud]

@Mugen87 Simple suggestion, as every control from examples/jsm/controls use camera as the first parameter of instantiation. Shouldn't the first parameter of base class Controls be called "camera" instead of "object" ?

three.js/examples/jsm/controls/Controls.js

Line 9 in 0536e00

this.object = object;

[Mugen87]

Thought about this as well^^. I've though it's more safe to use the generic name object if a control only manipulates a 3D object like a mesh. I wonder know if such an implementation would still require a reference to the scene's camera though...

[s-rigaud]

As there is 9 implementations of controls in the examples folder and we are not sure that even a new special control focus on a single mesh will not need the camera, wouldn't it be better to rename it now that not all the controls are using base class Controls instead of having to rename the attribute later on all the controls ? 🤔