RenderTransitionPass: Simplify render().
#28555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mugen87
commented
Jun 4, 2024
| @@ -220,7 +220,7 @@ | |||
| this.camera = camera; | |||
| this.mesh = mesh; | |||
|
|
|||
| this.render = function ( delta ) { | |||
| this.update = function ( delta ) { | |||
There was a problem hiding this comment.
This method renders nothing so using the name update() is less consufing.
Mugen87
commented
Jun 4, 2024
| @@ -179,9 +157,6 @@ class RenderTransitionPass extends Pass { | |||
|
|
|||
| } | |||
|
|
|||
| #include <tonemapping_fragment> | |||
| #include <colorspace_fragment> | |||
There was a problem hiding this comment.
Using OutputPass is mandatory so it's inconsistent if only RenderTransitionPass does tone mapping and color space conversion on its own.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #28174
Description
RenderTransitionPassshould only be used during a transition so itsrender()method can be simplified.