DRACOLoader: Fixed "onError doesn't propagate" when parsing file #28383
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the onError doesn't propagate in here: (missing the 6th argument)
three.js/examples/jsm/loaders/DRACOLoader.js
Lines 86 to 90 in 7e74aa5
while the onError is consumed here, see L101
three.js/examples/jsm/loaders/DRACOLoader.js
Lines 92 to 103 in 7e74aa5
This PR fixed that by adding onError to the 6th argument of
decodeDracoFile()