Editor: update Sidebar.Geometry.ExtrudeGeometry.js #28373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linbingquan
commented
May 14, 2024
Comment on lines
+144
to
147
| bevelThickness: thickness !== undefined ? thickness.getValue() : options.bevelThickness, | ||
| bevelSize: size !== undefined ? size.getValue() : options.bevelSize, | ||
| bevelOffset: offset !== undefined ? offset.getValue() : options.bevelOffset, | ||
| bevelSegments: segments !== undefined ? segments.getValue() : options.bevelSegments |
There was a problem hiding this comment.
If the PR is accepted, this part of the code should not require a judgment statement.
|
Do you mind sharing a JSON (Object/Scene Format) that holds an extruded mesh? The import via |
I was use svg file test it. <?xml version="1.0" encoding="UTF-8"?>
<svg xmlns="http://www.w3.org/2000/svg" width="30" height="30">
<rect x="0" y="0" width="30" height="30" fill="red" />
</svg> |
Mugen87
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #XXXX
Description
ShapeGeometry Extrude to ExtrudeGeometrydepth value error.ExtrudeGeometry.bevelEnabled.