Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebGLRenderer: Fixed compressed partial update on texture3D #27771

Merged
merged 2 commits into from
Feb 19, 2024
Merged

WebGLRenderer: Fixed compressed partial update on texture3D #27771

merged 2 commits into from
Feb 19, 2024

Conversation

RenaudRohlinger
Copy link
Collaborator

This PR fix the transferring compressed 2D texture into layers of a compressed 3D texture via copyTextureToTexture3D.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 19, 2024 •
edited
Loading

📦 Bundle size

Full ESM build, minified and gzipped.

Filesize dev Filesize PR Diff
676.4 kB (168.3 kB) 676.4 kB (168.2 kB) -86 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Filesize dev Filesize PR Diff
457.3 kB (111 kB) 457.2 kB (111 kB) -86 B

@Mugen87 Mugen87 added this to the r162 milestone Feb 19, 2024
@Mugen87 Mugen87 merged commit cfdd878 into mrdoob:dev Feb 19, 2024
12 checks passed
@RenaudRohlinger RenaudRohlinger mentioned this pull request Apr 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eiriklegernaes eiriklegernaes eiriklegernaes left review comments

@Mugen87 Mugen87 Mugen87 approved these changes

@mrdoob mrdoob mrdoob left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r162
Development

Successfully merging this pull request may close these issues.
4 participants
@RenaudRohlinger @mrdoob @Mugen87 @eiriklegernaes