Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EditorControls: Add duplicate pointer ID fix. #27749

Merged
merged 1 commit into from
Feb 14, 2024
Merged

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Feb 14, 2024

Related issue: #27748

Description

Applying the same pointer ID fix from OrbitControls to EditorControls.

@sciecode Given how similar controls handle multi pointer events, I wonder if we could centralize some logic into an upper class Controls (or PointerControls) and then extend from it 🤔 .

@Mugen87 Mugen87 added this to the r162 milestone Feb 14, 2024
@Mugen87 Mugen87 merged commit 3606ee1 into mrdoob:dev Feb 14, 2024
1 check was pending
@sciecode
Copy link
Contributor

@sciecode Given how similar controls handle multi pointer events, I wonder if we could centralize some logic into an upper class Controls and then extend from it 🤔 .

Yeah, they do look similar enough that is worth considering it.

There's always an extra effort having to debug things over multiple files & implementation specific behaviour might eventually diverge, but we can give it a try and revert later if it proves more trouble than it is worth.

Will see if I can come up with a draft PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants