Editor: Add compute tangents option. #27461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mugen87
commented
Dec 28, 2023
| @@ -133,6 +133,7 @@ function Strings( config ) { | |||
| 'sidebar/geometry/bounds': 'Bounds', | |||
| 'sidebar/geometry/show_vertex_normals': 'Show Vertex Normals', | |||
| 'sidebar/geometry/compute_vertex_normals': 'Compute Vertex Normals', | |||
| 'sidebar/geometry/compute_vertex_tangents': 'Compute Tangents', | |||
There was a problem hiding this comment.
@mrdoob I've used the shorter name Compute Tangents since Compute Vertex Tangents produces a line break inside the button.
AdaRoseCannon
pushed a commit
to AdaRoseCannon/three.js
that referenced
this pull request
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #27440
Description
Since the editor already supports the computation of normals, this PR adds a "compute tangents" option.