BufferAttribute: Deprecate .dynamic, introduce .usage. #17445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merging see #17454 (comment) The sooner it lands in |
|
Updated builds: 3a3d2b1 |
|
Thanks! |
WestLangley
reviewed
Dec 12, 2019
| <p> | ||
| Defines the intended usage pattern of the data store for optimization purposes. Corresponds to the *usage* parameter of | ||
| [link:https://developer.mozilla.org/en-US/docs/Web/API/WebGLRenderingContext/bufferData WebGLRenderingContext.bufferData](). | ||
| Default is *THREE.StaticDrawUsage*. |
There was a problem hiding this comment.
This needs to link to a description of the values it can take.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #14730
I've managed it to make the change backwards-compatible. So
BufferAttribute.dynamicandBufferAttribute.setDynamic()can still be used but with warnings. Same forInterleavedBuffer's interface.The new
usageproperty directly maps to the same-named parameter of WebGLRenderingContext.bufferData(). So this property is now only intended to define the usage pattern of the buffer data for optimization purposes.WebGLAttributes.updateBuffer()only usesbufferSubData()now. Keep in mind that the initial buffer upload is done withbufferData()as before.