-
-
Notifications
You must be signed in to change notification settings - Fork 35.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BufferAttribute: Introduce dispose(). #17063
Conversation
/bump overlooked? |
Resolved the merge conflicts. |
I think I need this right now! |
@mrdoob Any chances to merge the PR? If not, do you mind sharing your concerns about this change? Maybe we can find a different solution if this one is not satisfying? |
Note: there is currently no method to properly dispose I think this is really a glaring hole in the resource management. A proper cleanup should always be possible. Someone may have a scene with a lot of dynamic instancing going on (I am now experimenting with exactly such scene) and the missing cleanup causes slowing growing allocation of WebGL resources in such case. |
After a deeper analysis I do not vote to introduce
|
This PR replaces #15308. Fixed #15261.
A first step to make
BufferAttribute
fixed sized.The new policy should be: If you need to resize buffer data, you have to create a new instance of
BufferAttribute
.