-
-
Notifications
You must be signed in to change notification settings - Fork 35.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GLTFLoader: Add basic example. #13055
Conversation
debc1cd
to
0a04437
Compare
0a04437
to
4e9fac6
Compare
d40f480
to
193dacf
Compare
Personally I want the option to turn on/off |
examples/webgl_loader_gltf.html
Outdated
|
||
} | ||
scene.add.apply( scene, gltf.scene.children ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not strong preference but I prefer
scene.add( gltf.scene );
because I'm really not sure how well function.apply
style is known to JS (especially new) users.
If we don't wanna push gltf.scene
to scene
, the code would be like this?
or
while( gltf.scene.children.length > 0 ) {
scene.add( gltf.scene.children[ 0 ] );
}
(a bit complex?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure ✅
What is thst? |
Looks good |
@soljurami The description is at the top of the webpage. @donmccurdy I would remove the background and add black or white fog if you want to keep the floor/shadow -- or remove the floor and set a black background. IMHO. |
@WestLangley Why you wanna remove the background? For the simplicity? |
I think the background looks good here, and adds only a couple of lines of code. Even in these simple examples it's OK to demonstrate a couple of other basic techniques, such as adding floors, shadows, environment maps. |
I think the example floor and background in combination are ugly. My suggestions were based on aesthetics only. The first screenshot above looks very nice to me. Very professional. I'd go with that. |
If would pick the last option so no floor and grid. |
55c0359
to
1780443
Compare
Personally, I would not try to anticipate what new users would be confused by. I'd make the demo look as professional as possible. I understand that what looks good aesthetically is a personal preference. I do not like the sky background at all. The first screenshot looks fine to me -- with either black or white fog. Just my opinion, though. :) |
Don't you worry about it guys! I'll make sure it looks professional 😎 |
Thanks! |
I just realized I've misunderstood a bit. So the example looks fine. Update: environment map would be in extension but no in core KhronosGroup/glTF#946 |
Alright, after 25b71ec I think it looks a bit more "professional" 😁 |
Fixes #13041.