OBJLoader V2.2.1 #12896
Merged
OBJLoader V2.2.1 #12896
+82
−127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Original Repo Issue 27: Multiple mesh definitions (vertices, normals, uvs and faces) within one group are now supported. Needed to remove early release of vertex data from memory. - Original Repo Issue 28: Negative face indices are now supported. - Original Repo Issue 29: Cleaned loadMtl API and clarified `WorkerSupport.run` contract. Transferable is automatically attached if data is an ArrayBuffer.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following bugs were fixed:
WorkerSupport.runcontract. Transferable is automatically attached if data is an ArrayBuffer.Issues 27 and 28 resolved real parser bugs. Issue 29 includes the fixes of #12889.
I verified the loader against all objs gathered from previous issues and everything is fine (=no regressions)
Btw, I am currently working on a verification obj file that is created from code (will continue in January). It contains/will contain various special or corner cases (due to let's say flexibility the obj spec allows). It should help to build confidence in the parser and eventually provide enough trust that allows us to replace OBJLoader with OBJLoader2 (R90, let's see/discuss later 😄)