Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add EXRLoader example #12891

Merged
merged 2 commits into from
Dec 15, 2017
Merged

add EXRLoader example #12891

merged 2 commits into from
Dec 15, 2017

Conversation

richardmonette
Copy link
Contributor

@richardmonette richardmonette commented Dec 15, 2017

Adds a basic EXRLoader. Can read the header and uncompressed data.

I've added an example based of https://github.com/mrdoob/three.js/blob/dev/examples/webgl_materials_texture_hdr.html

I'd like to follow this up with better support of EXR feature, in particular PIZ compression.

related: #10652

cc @mrdoob

@richardmonette richardmonette mentioned this pull request Dec 15, 2017
@WestLangley
Copy link
Collaborator

On MacOS, Chrome is claiming the texture is NPOT ( 1023 x 511 to be exact ).

Also, the tone mapping is rendering way too dark. May be related.

Errors are thrown with Safari and the image is not rendered.

@richardmonette
Copy link
Contributor Author

@WestLangley thank you for your feedback, I believe my latest commit addresses the NPOT issues.

@WestLangley
Copy link
Collaborator

Yes, the issues I mentioned above appear to be resolved. Thanks.

@Mugen87
Copy link
Collaborator

Mugen87 commented Dec 15, 2017

@richardmonette Can you please add the new example to examples/files.js? Otherwise it won't appear in the navigation panel.

@mrdoob
Copy link
Owner

mrdoob commented Dec 15, 2017

@richardmonette Can you please add the new example to examples/files.js?

I'll do that.

@mrdoob mrdoob merged commit ec1d8ae into mrdoob:dev Dec 15, 2017
@mrdoob
Copy link
Owner

mrdoob commented Dec 15, 2017

Many thanks!

@WestLangley
Copy link
Collaborator

@mrdoob @Mugen87 FYI, I deleted the live link I added above; the link will break anyway when the OP deletes the topic branch. I think deleting the link is the best practice.

@mrdoob
Copy link
Owner

mrdoob commented Dec 16, 2017

@mrdoob @Mugen87 FYI, I deleted the live link I added above; the link will break anyway when the OP deletes the topic branch. I think deleting the link is the best practice.

I don't have strong feelings about this yet. If there were people complaining about broken links...

@WestLangley
Copy link
Collaborator

I think the addition of a live link, which used to be available via threejsworker, is a nice convenience for the reader. That is why I added it. It is of no value, however, once it is broken.

@mrdoob
Copy link
Owner

mrdoob commented Dec 16, 2017

Maybe it's a wording issue? "Ephemeral test link" 😁

@WestLangley
Copy link
Collaborator

"Ephemeral test link"

:-)

Yes. I have been adding an "ephemeral test link" in a separate comment so it can be removed when it becomes obsolete. @Mugen87 has been helpful in this regard, too.

@jxarco
Copy link

jxarco commented Feb 4, 2018

@richardmonette how about following the EXRLoader with the parsing of ZIP compression exr files?

And Is the parsing of PIZ compression exr files working?

Many thanks!

@richardmonette
Copy link
Contributor Author

Parsing compressed EXR files is significantly more complex than uncompressed.

I have, however, been working on upgrading the implementation to parse PIZ compressed files, as these seem to be the most common, and hope to have something for review in the near future.

@richardmonette
Copy link
Contributor Author

@jxarco I've put together an initial implementation of the PIZ wavelet decompression #13346

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants