-
-
Notifications
You must be signed in to change notification settings - Fork 35.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add EXRLoader example #12891
add EXRLoader example #12891
Conversation
On MacOS, Chrome is claiming the texture is NPOT ( 1023 x 511 to be exact ). Also, the tone mapping is rendering way too dark. May be related. Errors are thrown with Safari and the image is not rendered. |
@WestLangley thank you for your feedback, I believe my latest commit addresses the NPOT issues. |
Yes, the issues I mentioned above appear to be resolved. Thanks. |
@richardmonette Can you please add the new example to examples/files.js? Otherwise it won't appear in the navigation panel. |
I'll do that. |
Many thanks! |
I think the addition of a live link, which used to be available via |
Maybe it's a wording issue? "Ephemeral test link" 😁 |
:-) Yes. I have been adding an "ephemeral test link" in a separate comment so it can be removed when it becomes obsolete. @Mugen87 has been helpful in this regard, too. |
@richardmonette how about following the EXRLoader with the parsing of ZIP compression exr files? And Is the parsing of PIZ compression exr files working? Many thanks! |
Parsing compressed EXR files is significantly more complex than uncompressed. I have, however, been working on upgrading the implementation to parse PIZ compressed files, as these seem to be the most common, and hope to have something for review in the near future. |
Adds a basic EXRLoader. Can read the header and uncompressed data.
I've added an example based of https://github.com/mrdoob/three.js/blob/dev/examples/webgl_materials_texture_hdr.html
I'd like to follow this up with better support of EXR feature, in particular PIZ compression.
related: #10652
cc @mrdoob