Editor: Added shortcut ('f') for focusing on selection #12874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
While adding this in, I found that when you try to focus on the default Camera in the editor it throws an error since the camera isn't a child of the scene. It doesn't necessarily break anything, but I was wondering if that was an active decision or something that should be fixed. |
mrdoob
reviewed
Dec 14, 2017
|
|
||
| if ( editor.selected !== null ) { | ||
|
|
||
| editor.focusById( editor.selected.id ); |
There was a problem hiding this comment.
How about editor.focus( editor.selected ); instead?
There was a problem hiding this comment.
Yeah, that's a lot cleaner! I just changed it, and that fixed the bug that occurred when trying to focus on the camera as well, so that's nice.
Mugen87
approved these changes
Dec 14, 2017
|
Thanks! |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In many 3D applications such as Unity or Maya, the 'f' key is used as a shortcut to focus on the current selection. I figured adding that shortcut to the three.js editor would increase the productivity of those familiar with 3D applications.