New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Zip-compress .amf file #12845

Merged

mrdoob merged 1 commit into mrdoob:dev from takahirox:CompressAMF

Dec 12, 2017

Collaborator

takahirox commented Dec 10, 2017

This PR zip-compresses rook.amf file.

An AMF can be stored as zip-compressed text and AMFLoader supports zip-compressed AMF file loading.

https://en.wikipedia.org/wiki/Additive_Manufacturing_File_Format#Compression

Advantage

Reduce file size from 403KB to 49KB

Disadvantage

The diff of binary file can't be visible on version control system.
AMFLoader example needs to load jszip.min.js


          Zip-compress .amf file

62ed2b5

Mugen87 approved these changes

View reviewed changes

mrdoob merged commit 38f68d1 into mrdoob:dev

Owner

mrdoob commented Dec 12, 2017

Thanks!

takahirox deleted the CompressAMF branch

December 12, 2017 06:50

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet