Editor: Fixed broken object delete shortcuts #12820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now both backspace and delete will cause prompt to delete an object.
mrdoob
reviewed
Dec 7, 2017
|
|
||
| event.preventDefault(); // prevent browser back | ||
|
|
||
| break; | ||
| // fall-through |
There was a problem hiding this comment.
Oh, sorry, I thought it was a bug 😇
There was a problem hiding this comment.
No worries! I should have thrown in a comment when I noticed that in the initial code.
|
Ops! |
|
Thanks! |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now both backspace and delete will prompt to delete an object. Previously backspace would fall through to the logic of delete in the switch statement, so I made that explicit in a comment to avoid confusion.