Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

X-Loader example: use negative scale to mirror model #12794

Merged
merged 1 commit into from
Dec 5, 2017

Conversation

WestLangley
Copy link
Collaborator

With this PR, mesh.scale.x is used to mirror the model, rather than the XLoader zflag option, which is non-conventional.

This PR is based on #12787.

@adrs2002 Please have a look and comment.

@adrs2002
Copy link
Contributor

adrs2002 commented Dec 4, 2017

@WestLangley

I confirmed.
it is perfect!
I am looking forward to next version which this PR will marged.
I was convinced by this PR that [zflag] became unnecessary.

After this PR has been merged, I will fix XLoader again.
Thank you for solving!

@WestLangley
Copy link
Collaborator Author

@adrs2002 Do these changes work correctly on your track.x model?

@adrs2002
Copy link
Contributor

adrs2002 commented Dec 4, 2017

@WestLangley

yes. track.x confirmed that it was correctly displayed even in both -x and + x states!

@mrdoob mrdoob merged commit 7ce43c4 into mrdoob:dev Dec 5, 2017
@mrdoob
Copy link
Owner

mrdoob commented Dec 5, 2017

Thanks!

@WestLangley WestLangley deleted the dev-x branch December 5, 2017 16:19
@WestLangley
Copy link
Collaborator Author

@adrs2002 said

After this PR has been merged, I will fix XLoader again.

Go for it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants