Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GLTFLoader: Add renderer.gammaOutput=true to examples. #12766

Merged
merged 1 commit into from
Nov 28, 2017

Conversation

donmccurdy
Copy link
Collaborator

Fixes #12554. See #11110.

@takahirox
Copy link
Collaborator

takahirox commented Nov 28, 2017

I don't perfectly understand gamma color topics yet, but renderer.gammaOutput should always be true when GLTFLoader is used? I'm wondering if we should write this note to document or somewhere.

@donmccurdy
Copy link
Collaborator Author

I'm still figuring this out too, but from #11110 it sounds like gammaOutput=true should be preferred most of the time, regardless of model formats, unless you are doing post-processing.

@donmccurdy
Copy link
Collaborator Author

@mrdoob mrdoob merged commit 6b116a5 into mrdoob:dev Nov 28, 2017
@mrdoob
Copy link
Owner

mrdoob commented Nov 28, 2017

Thanks!

@mrdoob mrdoob mentioned this pull request Jul 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants