PropertyBinding: Organize TODO tests. #12765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
|
I have no prob with that. The fact was just the "red" test need to be reimplemented too. But don't worry ! |
|
Many "red" tests were passing — the errors were because passing tests were inside of TODO modules. Do they need to be re-implemented for some other reason? |
|
That is not what i would say sorry. Some module unit test "red" contain both. Todo and passing, but module using a todo will fail on them. So yes todo should be implemented on the test instead of the module to gain clarity ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Itee I think this is what should happen to all of the tests — mark individual tests as TODO rather than the module, and skip the TODOs for private methods. Does this seem right?
Related: #12714, #12759.