New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up GLTFLoader #12733

Merged

mrdoob merged 1 commit into mrdoob:dev from takahirox:gltfCleanUp

Nov 24, 2017

Collaborator

takahirox commented Nov 23, 2017

This PR cleans up _each() function of GLTFLoader a bit.

The third argument thisObj of _each() isn't used. We can remove.
In callback functions passed to _each(), this isn't used. We can replace callback.call( this, ... ) with callback( ... ).

/cc @donmccurdy


          Clean up GLTFLoader

18b094f

donmccurdy approved these changes

View reviewed changes

mrdoob merged commit c3a3b2d into mrdoob:dev

Owner

mrdoob commented Nov 24, 2017

Thanks!

takahirox deleted the gltfCleanUp branch

November 24, 2017 03:38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet