ShapeUtils: Use earcut for polygon triangulation (2nd attempt) #12661
Conversation
|
Just curious, was there a particular concern with using an npm dependency in the previous PR? |
Maybe just me being old fashioned and cautious 😇 |
|
Thanks! |
|
|
||
| bx = contour[ verts[ v ] ].x; | ||
| by = contour[ verts[ v ] ].y; | ||
| function earcut( data, holeIndices, dim ) { |
There was a problem hiding this comment.
Probably better to move this function to the top of the file? Otherwise we're going to be instantiating it every time we call to triangulate.
There was a problem hiding this comment.
Okay, but i think we have to move all functions (not only earcut) inside triangulate because they are on the same hierarchy. How about moving the code to a new file Earcut.js in src/extras instead? In this way, the code is a little bit better separated and organized.
There was a problem hiding this comment.
I've made a PR to see the result of this suggestion.
|
@Mugen87 Also, broken links to earcut examples still remain. |
|
@WestLangley I'm afraid i don't understand your feedback 😅 . To what kind of broken links do you refer? |
|
Ah, you mean the docs? That's right, i'll fix this! |
Successor of #12286 😊
This time i have re-written
ShapeUtils.triangulate()based on earcut. So it's just a simple port, no usage of a npm module and no further modifications. Nevertheless, many problems in context of triangulation should be solved with this implementation.