Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the ability to specify an alternative Object3D to the camera to apply the pose coming from a VRDevice #12651

Merged
merged 1 commit into from
Nov 17, 2017
Merged

Add the ability to specify an alternative Object3D to the camera to apply the pose coming from a VRDevice #12651

merged 1 commit into from
Nov 17, 2017

Conversation

dmarcos
Copy link
Contributor

@dmarcos dmarcos commented Nov 14, 2017

…

mrdoob
mrdoob reviewed Nov 15, 2017
View reviewed changes
src/renderers/webvr/WebVRManager.js Outdated
@@ -85,6 +85,14 @@ function WebVRManager( renderer ) {

};

this.headObject = null;

this.setHeadObject = function ( object ) {
Copy link
Owner

@mrdoob mrdoob Nov 15, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this.setPoseTarget = function ( object ) {?

mrdoob
mrdoob reviewed Nov 15, 2017
View reviewed changes
src/renderers/webvr/WebVRManager.js Outdated
@@ -85,6 +85,14 @@ function WebVRManager( renderer ) {

};

this.headObject = null;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't make this one public...

@dmarcos
Copy link
Contributor Author

dmarcos commented Nov 15, 2017

Ready 👍

@mrdoob
Copy link
Owner

mrdoob commented Nov 15, 2017

Should we also update the camera.updateMatrixWorld(); line?

@dmarcos
Copy link
Contributor Author

dmarcos commented Nov 15, 2017

Probably. Should the camera be always updated as well?

@dmarcos
Copy link
Contributor Author

dmarcos commented Nov 15, 2017

I'm calling now to poseObject.updateMatrixWorld I believe we still need to call both. In A-Frame the camera is a child of the poseObject.

@dmarcos
Copy link
Contributor Author

dmarcos commented Nov 15, 2017

I know just call poseObject.updateMatrixWorld() that should also update the camera matrixWorld when it is a child of the poseObject

@mrdoob
Copy link
Owner

mrdoob commented Nov 17, 2017

How do you guys handle standing?

https://github.com/mrdoob/three.js/blob/dev/src/renderers/webvr/WebVRManager.js#L119-L129

Should I get rid of that code? In the webvr examples I opted for adding a user Group.

3cb51d8#diff-bfebe34154a0dfd9fc7b447fc9ed74e9

@dmarcos
Copy link
Contributor Author

dmarcos commented Nov 17, 2017

@mrdoob We have a 1.6 default height on 3DOF headsets to always simulate standing and we just apply whatever position comes from 6DOF headsets. We don't use that code so we're ok with getting rid of it.

@mrdoob
Copy link
Owner

mrdoob commented Nov 17, 2017

Oks!

@mrdoob mrdoob merged commit 1ec24e5 into mrdoob:dev Nov 17, 2017
@mrdoob
Copy link
Owner

mrdoob commented Nov 17, 2017

Thanks!

Repository owner deleted a comment from dmarcos Nov 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrdoob mrdoob mrdoob left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dmarcos @mrdoob