Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Example: Prevent material.needsUpdate being true every frame #12628

Merged
merged 1 commit into from
Nov 10, 2017
Merged

Example: Prevent material.needsUpdate being true every frame #12628

merged 1 commit into from
Nov 10, 2017

Conversation

WestLangley
Copy link
Collaborator

Maybe there is a cleaner way of doing this, but I think this is OK for an example.

The problem was that a string was being compared with an integer.

@mrdoob mrdoob merged commit 4e8a8c1 into mrdoob:dev Nov 10, 2017
@mrdoob
Copy link
Owner

mrdoob commented Nov 10, 2017

Thanks!

@WestLangley WestLangley deleted the dev-materials_channels branch November 10, 2017 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mugen87 Mugen87 Mugen87 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@WestLangley @mrdoob @Mugen87