ColladaLoader: Added possibility to manually set path

[cnspaha]

see #12609

@Mugen87

[donmccurdy]

I would make this:

var path = scope.path === undefined ? THREE.Loader.prototype.extractUrlBase( url ) : scope.path;

Otherwise consider this case:

var loader = new THREE.ColladaLoader();
loader.load('path/to/first/model.dae', () => ...);
loader.load('other/path/to/second/model.dae', () => ...);

The first model will modify scope.path and break the second model.

[Mugen87]

If we do it like this, we also handle the path for textureLoader correctly, see

https://github.com/cnspaha/three.js/blob/18b700af3c3e50f82a8112f54061af212db8011e/examples/js/loaders/ColladaLoader.js#L3367

@cnspaha The path variable at this place is passed as a parameter of parse(). With your current implementation, this value isn't set correctly.

[Mugen87]

I think it would be the best to handle this in the same way like GLTFLoader does.

[cnspaha]

@donmccurdy
I get your point.
Just saw, that I pretty messed up this one...
I like your idea, thanks again for your input ;)

@Mugen87
The suggestion of @donmccurdy is exactly what the GLTFLoader does, isn't it?

edit: commited it

[Mugen87]

This line is not necessary. Everything else is fine.

[cnspaha]

done.

[Mugen87]

Sry for being so pedantic. But it seems you used soft tabs here. Please ensure correct code style by using hard tabs instead.

[cnspaha]

don't worry about it, you are totaly right ;)
didn't pay attention to this one

[Mugen87]

Looks good now! Thanks!

[cnspaha]

@mrdoob
can you merge this please? Thank you :)

[Mugen87]

@mrdoob This one can be safely merged 😊

[mrdoob]

Sorry for the delay guys!

[mrdoob]

Thanks!