Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GLTFLoader: Support sparse accessors. #12596

Merged
merged 2 commits into from
Nov 22, 2017
Merged

GLTFLoader: Support sparse accessors. #12596

merged 2 commits into from
Nov 22, 2017

Conversation

donmccurdy
Copy link
Collaborator

@zellski zellski mentioned this pull request Nov 15, 2017
Open
@takahirox
Copy link
Collaborator

Any reasons that this PR doesn't care sparse.count, sparse.indices.byteOffset, and sparse.values.byteOffset?

@donmccurdy
Copy link
Collaborator Author

You're right, those should be checked... pushed a change that I think fixes it, but I don't have the test model on this computer so let me verify it later today.

@donmccurdy
Copy link
Collaborator Author

Ok, I think it's all set.

@takahirox
Copy link
Collaborator

Looks ok to me now.

@mrdoob mrdoob merged commit a8a6e1f into mrdoob:dev Nov 22, 2017
@mrdoob
Copy link
Owner

mrdoob commented Nov 22, 2017

Thanks!

@cx20
Copy link
Contributor

cx20 commented Nov 22, 2017

I updated the status of gltf-test. Three.js is all green again.
https://github.com/cx20/gltf-test#gltf-20-sample-models

https://cx20.github.io/gltf-test/examples/threejs/index.html?category=tutorialModels&model=SimpleSparseAccessor&scale=1&type=glTF

@donmccurdy donmccurdy deleted the feat-gltf-sparse-accessors branch November 22, 2017 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@donmccurdy @takahirox @mrdoob @cx20