Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Fix SpotLightShadow.camera.fov default value #12448

Merged
merged 2 commits into from
Nov 3, 2017
Merged

Docs: Fix SpotLightShadow.camera.fov default value #12448

merged 2 commits into from
Nov 3, 2017

Conversation

vidartf
Copy link
Contributor

@vidartf vidartf commented Oct 20, 2017

The actual default value of SpotLightShadow.camera.fov is 50, while the docs currently say 90.

@vidartf
Copy link
Contributor Author

vidartf commented Oct 20, 2017

Actually, the FOV of the camera is automatically updated to the angle of the SpotLight when rendering (which should make the default FOV 60 deg given the default SpotLight angle of PI/3). I'll update the PR to reflect this.

@vidartf
Copy link
Contributor Author

vidartf commented Nov 3, 2017

Updated with new text to detail the tracking of owning SpotLight for shadow camera properties.

@mrdoob mrdoob merged commit ff26258 into mrdoob:dev Nov 3, 2017
@mrdoob
Copy link
Owner

mrdoob commented Nov 3, 2017

Thanks!

@vidartf vidartf deleted the patch-1 branch November 4, 2017 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mugen87 Mugen87 Mugen87 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vidartf @mrdoob @Mugen87