Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GLTF2Loader: Remove unused shader extension. #11929

Merged
merged 1 commit into from
Aug 14, 2017

Conversation

donmccurdy
Copy link
Collaborator

Shaders were removed from the core specification with glTF2.0, and will eventually be defined through an optional extension, KHR_technique_webgl. But that spec hasn't been created yet, and there are multiple higher-priority extensions to finish first (lights, Draco, Blinn-Phong materials...). When the extension does get defined, it may very possibly be targeting WebGL 2.0.

So in the interest of maintaining and refactoring the existing loader, I'd like to remove the currently-defunct KHR_technique_webgl code. 😢 We can always resurrect it when the time is right.

This also simplifies our .clone() issues significantly.

/cc @takahirox

@takahirox
Copy link
Collaborator

takahirox commented Aug 13, 2017

IMO, removing and simplifying are nice if the current glTF loader shader is old spec.

@mrdoob mrdoob merged commit c773ace into mrdoob:dev Aug 14, 2017
@mrdoob
Copy link
Owner

mrdoob commented Aug 14, 2017

Thanks!

@takahirox
Copy link
Collaborator

BTW what glTF spec threads should I see to follow the shader and extension priority discussion?

@donmccurdy
Copy link
Collaborator Author

donmccurdy commented Aug 16, 2017

@takahirox active issues in the glTF repo are a reasonably good indicator; some more urgent ones are:

The Draco team is helping with the three.js implementation for KhronosGroup/glTF#874, also.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants