GLTF2Loader: Remove unused shader extension. #11929
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shaders were removed from the core specification with glTF2.0, and will eventually be defined through an optional extension,
KHR_technique_webgl
. But that spec hasn't been created yet, and there are multiple higher-priority extensions to finish first (lights, Draco, Blinn-Phong materials...). When the extension does get defined, it may very possibly be targeting WebGL 2.0.So in the interest of maintaining and refactoring the existing loader, I'd like to remove the currently-defunct KHR_technique_webgl code. 😢 We can always resurrect it when the time is right.
This also simplifies our
.clone()
issues significantly./cc @takahirox