Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SpriteNodeMaterial and example #11531

Merged
merged 7 commits into from
Jun 16, 2017
Merged

SpriteNodeMaterial and example #11531

merged 7 commits into from
Jun 16, 2017

Conversation

sunag
Copy link
Collaborator

@sunag sunag commented Jun 16, 2017

Finally news 😊
#5876

@mrdoob
Copy link
Owner

mrdoob commented Jun 16, 2017

Nice!

@mrdoob mrdoob merged commit aef4f28 into mrdoob:dev Jun 16, 2017
@mrdoob
Copy link
Owner

mrdoob commented Jun 16, 2017

Thanks!

@mrdoob
Copy link
Owner

mrdoob commented Jun 16, 2017

How about replacing all these THREE.ShaderChunk[ "project_vertex" ] with #include <project_vertex>?

We currently run this on shaders:
https://github.com/mrdoob/three.js/blob/dev/src/renderers/webgl/WebGLProgram.js#L153-L173

@sunag
Copy link
Collaborator Author

sunag commented Jun 16, 2017

Only the project_vertex or all others shaderchucks too?

@mrdoob
Copy link
Owner

mrdoob commented Jun 16, 2017

All of them 😇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants