Abelnation RectAreaLight with ltc approximation #10041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion left in place
Fix broken references to THREE namespace in geometries.
…ttps://github.com/abelnation/three.js into abelnation-polygonal-light-shading-linear-transformed-cosines # Conflicts: # src/renderers/WebGLRenderer.js # src/renderers/shaders/ShaderLib.js # src/renderers/shaders/UniformsLib.js # src/renderers/shaders/UniformsUtils.js # src/renderers/webgl/WebGLLights.js # src/renderers/webgl/WebGLProgram.js # utils/build/includes/common.json # utils/build/includes/extras.json # utils/build/includes/math.json
…ygonal-light-shading-linear-transformed-cosines
Noticed that the code from @abelnation is not his latest... more merging to come!!!
…ub.com/abelnation/three.js into abelnation-rect-area-light-with-ltc-approximation # Conflicts: # examples/files.js # examples/webgl_lights_rectarealight.html # src/extras/helpers/RectAreaLightHelper.js # src/lights/RectAreaLight.js # src/renderers/WebGLRenderer.js # src/renderers/shaders/ShaderChunk/bsdfs.glsl # src/renderers/shaders/ShaderChunk/common.glsl # src/renderers/shaders/ShaderChunk/lights_lambert_vertex.glsl # src/renderers/shaders/ShaderChunk/lights_pars.glsl # src/renderers/shaders/ShaderChunk/lights_phong_pars_fragment.glsl # src/renderers/shaders/ShaderChunk/lights_template.glsl # src/renderers/shaders/ShaderChunk/shadowmask_pars_fragment.glsl # src/renderers/shaders/ShaderLib.js # src/renderers/shaders/UniformsLib.js # src/renderers/webgl/WebGLProgram.js # src/renderers/webgl/WebGLPrograms.js # src/textures/Texture.js # test/unit/lights/RectAreaLight.tests.js # utils/build/includes/common.json # utils/build/includes/extras.json
webgl_lights_arealight improved RectAreaLightHelper update bugs fixed
* save typed array info in attribute properties * use saved attribute properties * remove unused variable
…odified after initial rendering (#9512) * add setDiscardBuffer method to BufferGeometry * added discard support to BufferAttribute * add mechanism for discard of BufferAttribute TypedArrays * use more elegant method for creating dummy typed array. * fix typo * Update BufferGeometry.js fix brain fade * rework to use callbacks (phase 1) * rework part 2 * remove build file * support setting onUploadCallback from Geometry * remove repeated calculation from renderer * remove now redundant getter * remove geoemtry interface * document discard mechanism. * merge fixes * restore return.this * drop unneeded call() * rename discard() method to disposeArray()
* added missing methods * Finished add methods * redid changed to WebGLRenderer.html
* Created documentation for DepthTexture * pulled upstream * added missing comma to docs/list.js
…ion-rect-area-light-with-ltc-approximation # Conflicts: # build/three.js # build/three.modules.js
|
awesome awesome! thanks for putting in the work to get this working with the latest updates! |
|
Would it be possible to not include the builds in the PR? There is also a ton of things that I would like to remove (mainly the whole |
|
Actually, seems like it has no conflicts, so I'll merge and do the clean up. |
|
Thanks! |
sam-g-steel
deleted the
abelnation-rect-area-light-with-ltc-approximation
branch
|
Awesome!!! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brought the code up to date so it can be merged without conflict.
#9234