-
-
Notifications
You must be signed in to change notification settings - Fork 35.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IE11: 'Uint8ClampedArray' is undefined #11440
Comments
Apparently the support for That means that the bug should be reproduced just in older build of IE11. |
I'm not convinced it is appropriate to provide a fix here. The mentioned IE11 update is from 2014, right? That's pretty old. I think users need to upgrade their browser if they actually run into this problem. @luruke Is this possible in your case? BTW: We also use |
Hello @Mugen87. I'm ok to not support older build of IE11 , but at least we should add a check, in order to avoid to break all the javascript in the page. Worth mentioning is that to reproduce the bug, is enough to load three js, even without using it. Strangely enough, when I tried, the |
I think because of 43d6053 Before this change, the variable |
@luruke Was not aware about that. Any ideas how to improve the situation? Unfortunately, i'm unable to test and reproduce this on my machine. |
@Mugen87 I'm using BrowserStack to replicate the issue. I'm more than happy to create a pull request. What about a simple: Uint8ClampedArray: typeof Uint8ClampedArray !== 'undefined' ? Uint8ClampedArray : Uint8Array, Or it's better to move back the What I want for the moment is just make sure that the JavaScript code is correctly parsed, so I can gracefully degrade (aka not running the webgl part) on my website when running on IE11 (or when Uint8ClampedArray not available). BTW this is not the only problem with this old IE11 build: As you can see webgl is supported, the basic cube spinning is not working with r84, while an old demo r55 is working. In any case this is not my biggest concern, also considering that on browserstack windows is probably running on very limited video card / old drivers. |
Before creating a PR, i'd like to wait what other developers say about this issue. Besides, i've made bad experiences with testing graphic intensive applications in VMs. They sometimes report errors or warnings that don't occur on physical machines. |
That sounds like an okay workaround to me. |
Fix syntax error on older builds of IE11 #11440
Hello, starting from r85 threejs seems broken on IE11 (via browserstack at least).
The problems seems to be here:
three.js/src/loaders/BufferGeometryLoader.js
Line 96 in 49071e5
Anyone has the same problem?
Three.js version
Browser
OS
The text was updated successfully, but these errors were encountered: