WebGPURenderer: TimestampQuery constant (#30375)

mrdoob · Jan 23, 2025 · b18d74c · b18d74c
1 parent 98a3fa3
commit b18d74c
Show file tree

Hide file tree

Showing 6 changed files with 11 additions and 6 deletions.
diff --git a/examples/webgpu_compute_birds.html b/examples/webgpu_compute_birds.html
@@ -505,7 +505,7 @@
 
 				renderer.compute( computeVelocity );
 				renderer.compute( computePosition );
-				renderer.resolveTimestampsAsync( 'compute' );
+				renderer.resolveTimestampsAsync( THREE.TimestampQuery.COMPUTE );
 				renderer.render( scene, camera );
 
 				// Move pointer away so we only affect birds when moving the mouse

diff --git a/examples/webgpu_compute_particles_snow.html b/examples/webgpu_compute_particles_snow.html
@@ -350,7 +350,7 @@
 				// compute
 
 				renderer.compute( computeParticles );
-				renderer.resolveTimestampsAsync( 'compute' );
+				renderer.resolveTimestampsAsync( THREE.TimestampQuery.COMPUTE );
 
 				// result
 

diff --git a/examples/webgpu_compute_points.html b/examples/webgpu_compute_points.html
@@ -176,7 +176,7 @@
 			function animate() {
 
 				renderer.compute( computeNode );
-				renderer.resolveTimestampsAsync( 'compute' );
+				renderer.resolveTimestampsAsync( THREE.TimestampQuery.COMPUTE );
 
 				renderer.render( scene, camera );
 

diff --git a/examples/webgpu_performance.html b/examples/webgpu_performance.html
@@ -160,7 +160,7 @@
 			async function render() {
 
 				await renderer.renderAsync( scene, camera );
-				renderer.resolveTimestampsAsync( 'render' );
+				renderer.resolveTimestampsAsync( THREE.TimestampQuery.RENDER );
 
 				stats.update();
 

diff --git a/src/constants.js b/src/constants.js
@@ -209,3 +209,8 @@ export const GLSL3 = '300 es';
 
 export const WebGLCoordinateSystem = 2000;
 export const WebGPUCoordinateSystem = 2001;
+
+export const TimestampQuery = {
+	COMPUTE: 'compute',
+	RENDER: 'render'
+};
diff --git a/src/nodes/accessors/Arrays.js b/src/nodes/accessors/Arrays.js
@@ -9,7 +9,7 @@ import { getLengthFromType, getTypedArrayFromType } from '../core/NodeUtils.js';
  * TSL function for creating a storage buffer node with a configured `StorageBufferAttribute`.
  *
  * @function
- * @param {Number|TypedArray} count - The data count.
+ * @param {Number|TypedArray} count - The data count. It is also valid to pass a typed array as an argument.
  * @param {String} [type='float'] - The data type.
  * @returns {StorageBufferNode}
  */
@@ -29,7 +29,7 @@ export const attributeArray = ( count, type = 'float' ) => {
  * TSL function for creating a storage buffer node with a configured `StorageInstancedBufferAttribute`.
  *
  * @function
- * @param {Number|TypedArray} count - The data count.
+ * @param {Number|TypedArray} count - The data count. It is also valid to pass a typed array as an argument.
  * @param {String} [type='float'] - The data type.
  * @returns {StorageBufferNode}
  */