forked from dagster-io/dagster
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add compatibility for JSON output of dbt>=0.19.0.
Summary: Intended to resolve [issue dagster-io#3616](dagster-io#3616) The JSON schema for dbt run results (among many other [dbt Artifacts](https://docs.getdbt.com/reference/artifacts/dbt-artifacts)) has [changed in dbt 0.19.0](https://github.com/fishtown-analytics/dbt/releases/tag/v0.19.0). dagster-dbt currently fails when parsing the output from `dbt run` and `dbt compile`. This diff sets missing fields as optional and should be compatible with dbt //before// and //after// 0.19.0 **To Do** - [ ] Decide on how long dagster-dbt will support dbt <0.19.0. Please comment below with your thoughts. - [ ] Include new metadata fields from dbt 0.19.0 in the dagster-dbt Outputs and AssetMaterializations Test Plan: buildkite Reviewers: sandyryza, max Reviewed By: max Differential Revision: https://dagster.phacility.com/D6407
- Loading branch information
Bob Chen
authored and
David Laing
committed
Feb 20, 2021
1 parent
fd74ec7
commit 3248098
Showing
3 changed files
with
8 additions
and
8 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters